[cdwg] Monitoring Ticket Progress

Christopher J. Morrone morrone2 at llnl.gov
Fri Aug 2 15:27:08 PDT 2013


Thanks Denis, those are some great leads!

I think it would be excellent to investigate one or both of those links 
to get gerrit enhanced to match our workflow.  I opened ticket LU-3690 
as a task to track this.

I like the sounds of the prolog-cookbook approach.  But I see what you 
mean, it is not clear to me that making a patch "submitable" is 
sufficient to give us something that we can use as search term.  So that 
may make the perl "hook for a +2 approval from a simple quorum of +1 
votes" a better option.

I am not sure that I understood your final comment about a Jira 
"Landing" state.

Chris

On 08/02/2013 04:13 AM, Denis Kondratenko wrote:
> Chris,
>
> I see your point now. We are not using gerrit with a way it was designed
> for (when +2 should be there to submit; seems our gatekeepers doing +2).
> You are right it is impossible to build search for gatekeeper from plain
> gerrit without it modification.
>
> There are still some ways to workaround that:
> * http://en.wikibooks.org/wiki/Git/Gerrit_Code_Review (A hook could -
> for instance - allow a project to install an automated gatekeeper to
> vote +2 'submit approved' when sufficient +1 votes 'looks good to me'
> have been received)
> *
> http://review.whamcloud.com/Documentation/prolog-cookbook.html#_example_12_1_1_2_code_review (but
> I don't know if it will get right searches..)
> * in Xyratex we are using Jira state "Landing" to build filter for
> gatekeeper.
>
> OK, even if we could't separate gatekeeper changes from other, filter is
> still useful to check issues with no feedback for a long time.
>
> Thanks,
> Denis
>
>
> ------------------------------------------------------------------------
> For additional information including the registered office and the treatment of Xyratex confidential information please visitwww.xyratex.com  <http://www.xyratex.com/>
>
> ------------------------------------------------------------------------
>
>
> _______________________________________________
> cdwg mailing list
> cdwg at lists.opensfs.org
> http://lists.opensfs.org/listinfo.cgi/cdwg-opensfs.org
>




More information about the cdwg mailing list